mirror of
https://github.com/slhaf/Partner.git
synced 2026-06-28 01:59:17 +08:00
refactor(impression): expose choice of keepOldSubjectAsAlias in ImpressionCore
This commit is contained in:
@@ -60,7 +60,7 @@ public interface CognitionCapability {
|
|||||||
/**
|
/**
|
||||||
* Rename the canonical subject of a known entity and refresh entity/active-entity indexes.
|
* Rename the canonical subject of a known entity and refresh entity/active-entity indexes.
|
||||||
*/
|
*/
|
||||||
boolean renameEntitySubject(String entityUuid, String newSubject);
|
boolean renameEntitySubject(String entityUuid, String newSubject, boolean keepOldSubjectAsAlias);
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Add an alias or mention form for a known entity and refresh entity indexes.
|
* Add an alias or mention form for a known entity and refresh entity indexes.
|
||||||
|
|||||||
@@ -154,16 +154,16 @@ public class ImpressionCore implements StateSerializable {
|
|||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Rename the canonical subject of a known entity and keep its previous subject as a historical alias.
|
* Rename the canonical subject of a known entity and optionally keep its previous subject as a historical alias.
|
||||||
*/
|
*/
|
||||||
@CapabilityMethod
|
@CapabilityMethod
|
||||||
public boolean renameEntitySubject(String entityUuid, String newSubject) {
|
public boolean renameEntitySubject(String entityUuid, String newSubject, boolean keepOldSubjectAsAlias) {
|
||||||
Entity entity = knownEntitiesByUuid.get(entityUuid);
|
Entity entity = knownEntitiesByUuid.get(entityUuid);
|
||||||
if (entity == null || newSubject == null || newSubject.isBlank()) {
|
if (entity == null || newSubject == null || newSubject.isBlank()) {
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
|
||||||
boolean renamed = entity.renameSubject(newSubject.trim());
|
boolean renamed = entity.renameSubject(newSubject.trim(), keepOldSubjectAsAlias);
|
||||||
if (!renamed) {
|
if (!renamed) {
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -175,7 +175,7 @@ class CommunicationProducerTest {
|
|||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public boolean renameEntitySubject(String entityUuid, String newSubject) {
|
public boolean renameEntitySubject(String entityUuid, String newSubject, boolean keepOldSubjectAsAlias) {
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -128,7 +128,7 @@ class MemoryRuntimeTest {
|
|||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public boolean renameEntitySubject(String entityUuid, String newSubject) {
|
public boolean renameEntitySubject(String entityUuid, String newSubject, boolean keepOldSubjectAsAlias) {
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user