From 0211ba9ac881ed281d9cc2fd5bf0f3bd535e53ad Mon Sep 17 00:00:00 2001 From: slhafzjw Date: Sun, 14 Jun 2026 16:42:05 +0800 Subject: [PATCH] refactor(impression): expose choice of keepOldSubjectAsAlias in ImpressionCore --- .../slhaf/partner/core/cognition/CognitionCapability.java | 2 +- .../partner/core/cognition/impression/ImpressionCore.java | 6 +++--- .../module/communication/CommunicationProducerTest.java | 2 +- .../partner/module/memory/runtime/MemoryRuntimeTest.java | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Partner-Core/src/main/java/work/slhaf/partner/core/cognition/CognitionCapability.java b/Partner-Core/src/main/java/work/slhaf/partner/core/cognition/CognitionCapability.java index 1f8eca5c..870251d6 100644 --- a/Partner-Core/src/main/java/work/slhaf/partner/core/cognition/CognitionCapability.java +++ b/Partner-Core/src/main/java/work/slhaf/partner/core/cognition/CognitionCapability.java @@ -60,7 +60,7 @@ public interface CognitionCapability { /** * Rename the canonical subject of a known entity and refresh entity/active-entity indexes. */ - boolean renameEntitySubject(String entityUuid, String newSubject); + boolean renameEntitySubject(String entityUuid, String newSubject, boolean keepOldSubjectAsAlias); /** * Add an alias or mention form for a known entity and refresh entity indexes. diff --git a/Partner-Core/src/main/java/work/slhaf/partner/core/cognition/impression/ImpressionCore.java b/Partner-Core/src/main/java/work/slhaf/partner/core/cognition/impression/ImpressionCore.java index 3392d4f4..f490aba8 100644 --- a/Partner-Core/src/main/java/work/slhaf/partner/core/cognition/impression/ImpressionCore.java +++ b/Partner-Core/src/main/java/work/slhaf/partner/core/cognition/impression/ImpressionCore.java @@ -154,16 +154,16 @@ public class ImpressionCore implements StateSerializable { } /** - * Rename the canonical subject of a known entity and keep its previous subject as a historical alias. + * Rename the canonical subject of a known entity and optionally keep its previous subject as a historical alias. */ @CapabilityMethod - public boolean renameEntitySubject(String entityUuid, String newSubject) { + public boolean renameEntitySubject(String entityUuid, String newSubject, boolean keepOldSubjectAsAlias) { Entity entity = knownEntitiesByUuid.get(entityUuid); if (entity == null || newSubject == null || newSubject.isBlank()) { return false; } - boolean renamed = entity.renameSubject(newSubject.trim()); + boolean renamed = entity.renameSubject(newSubject.trim(), keepOldSubjectAsAlias); if (!renamed) { return false; } diff --git a/Partner-Core/src/test/java/work/slhaf/partner/module/communication/CommunicationProducerTest.java b/Partner-Core/src/test/java/work/slhaf/partner/module/communication/CommunicationProducerTest.java index cb9045cd..40b58237 100644 --- a/Partner-Core/src/test/java/work/slhaf/partner/module/communication/CommunicationProducerTest.java +++ b/Partner-Core/src/test/java/work/slhaf/partner/module/communication/CommunicationProducerTest.java @@ -175,7 +175,7 @@ class CommunicationProducerTest { } @Override - public boolean renameEntitySubject(String entityUuid, String newSubject) { + public boolean renameEntitySubject(String entityUuid, String newSubject, boolean keepOldSubjectAsAlias) { return false; } diff --git a/Partner-Core/src/test/java/work/slhaf/partner/module/memory/runtime/MemoryRuntimeTest.java b/Partner-Core/src/test/java/work/slhaf/partner/module/memory/runtime/MemoryRuntimeTest.java index d1eb94ef..f8868bc8 100644 --- a/Partner-Core/src/test/java/work/slhaf/partner/module/memory/runtime/MemoryRuntimeTest.java +++ b/Partner-Core/src/test/java/work/slhaf/partner/module/memory/runtime/MemoryRuntimeTest.java @@ -128,7 +128,7 @@ class MemoryRuntimeTest { } @Override - public boolean renameEntitySubject(String entityUuid, String newSubject) { + public boolean renameEntitySubject(String entityUuid, String newSubject, boolean keepOldSubjectAsAlias) { return false; }