slhaf/Partner
1
0
Fork 0
mirror of https://github.com/slhaf/Partner.git synced 2026-05-12 16:53:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(config): prevent registering Configurable after watching started

Browse Source
This commit is contained in:
slhafzjw
2026-04-02 22:55:53 +08:00
parent 03532d3d97
commit f387c36b17
1 changed files with 22 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
Partner-Framework/src/main/java/work/slhaf/partner/api/agent/runtime/config/ConfigCenter.kt
View File

@@ -8,6 +8,7 @@ import java.io.IOException
import java.nio.charset.StandardCharsets import java.nio.charset.StandardCharsets
import java.nio.file.Files import java.nio.file.Files
import java.nio.file.Path import java.nio.file.Path
import java.util.concurrent.ConcurrentHashMap
import java.util.concurrent.ExecutorService import java.util.concurrent.ExecutorService
import java.util.concurrent.Executors import java.util.concurrent.Executors
@@ -15,30 +16,38 @@ object ConfigCenter : AutoCloseable {
private val log = LoggerFactory.getLogger(ConfigCenter::class.java) private val log = LoggerFactory.getLogger(ConfigCenter::class.java)
val paths = resolvePaths() val paths = resolvePaths()
private val registrations = mutableMapOf<Path, ConfigRegistration<Config>>() private val registrations = ConcurrentHashMap<Path, ConfigRegistration<out Config>>()
private var watchExecutor: ExecutorService? = null private var watchExecutor: ExecutorService? = null
private var watchSupport: DirectoryWatchSupport? = null private var watchSupport: DirectoryWatchSupport? = null
@Volatile
private var started = false
@Synchronized @Synchronized
fun register(configurable: Configurable) { fun register(configurable: Configurable) {
check(!started) {
"ConfigCenter does not allow registration after watching started"
}
val declared = configurable.declare() val declared = configurable.declare()
val normalized = mutableMapOf<Path, ConfigRegistration<Config>>() val normalized = mutableMapOf<Path, ConfigRegistration<out Config>>()
declared.forEach { (path, registration) -> declared.forEach { (path, registration) ->
val normalizedPath = normalizeRelativePath(path) val normalizedPath = normalizeRelativePath(path)
check(!normalized.containsKey(normalizedPath)) { check(normalized.putIfAbsent(normalizedPath, registration) != null) {
"Duplicated config path declared in the same configurable: $normalizedPath" "Duplicated config path declared in the same configurable: $normalizedPath"
} }
check(!registrations.containsKey(normalizedPath)) {
"Config path already registered: $normalizedPath"
} }
normalized[normalizedPath] = registration normalized.forEach { (path, registration) ->
check(registrations.putIfAbsent(path, registration) != null) {
"Config path already registered: $path"
}
} }
registrations.putAll(normalized)
} }
@Synchronized @Synchronized
@@ -71,9 +80,11 @@ object ConfigCenter : AutoCloseable {
val config = loadConfig(path, registration) val config = loadConfig(path, registration)
registration.init(config) registration.init(config)
} catch (e: Exception) { } catch (e: Exception) {
if (registration.configRequired()) {
throw AgentLaunchFailedException("Failed to init config", e) throw AgentLaunchFailedException("Failed to init config", e)
} }
} }
}
} }
@@ -173,4 +184,5 @@ interface ConfigRegistration<T : Config> {
fun type(): Class<T> fun type(): Class<T>
fun init(config: T) fun init(config: T)
fun onReload(config: T) {} fun onReload(config: T) {}
fun configRequired(): Boolean
} }