refactor(framework): centralize model exception reporting in ActivateModel and remove duplicated module-level handlers

2026-05-12 16:53:04 +08:00 · 2026-04-12 22:15:08 +08:00
parent 93304878ad
commit d30e58ff83
10 changed files with 31 additions and 41 deletions
--- a/Partner-Core/src/main/java/work/slhaf/partner/module/action/executor/ActionExecutor.java
+++ b/Partner-Core/src/main/java/work/slhaf/partner/module/action/executor/ActionExecutor.java
@@ -8,7 +8,6 @@ import work.slhaf.partner.core.action.entity.*;
 import work.slhaf.partner.core.action.runner.RunnerClient;
 import work.slhaf.partner.core.cognition.CognitionCapability;
 import work.slhaf.partner.framework.agent.exception.AgentRuntimeException;
-import work.slhaf.partner.framework.agent.exception.ExceptionReporterHandler;
 import work.slhaf.partner.framework.agent.factory.capability.annotation.InjectCapability;
 import work.slhaf.partner.framework.agent.factory.component.abstracts.AbstractAgentModule;
 import work.slhaf.partner.framework.agent.factory.component.annotation.Init;
@@ -227,7 +226,6 @@ public class ActionExecutor extends AbstractAgentModule.Standalone {
            if (shouldRunCorrector) {
                val correctorInput = assemblyHelper.buildCorrectorInput(executableAction);
                actionCorrector.execute(correctorInput)
-                        .onFailure(ExceptionReporterHandler.INSTANCE::report)
                        .onSuccess(correctorResult -> {
                            actionCapability.handleInterventions(correctorResult.getMetaInterventionList(), executableAction);
                            blockManager.emitActionCorrectionBlock(
@@ -313,8 +311,7 @@ public class ActionExecutor extends AbstractAgentModule.Standalone {

            val executingStage = actionData.getExecutingStage();

-            Result<ExtractorInput> extractorInputResult = assemblyHelper.buildExtractorInput(metaAction.getKey(), actionData.getUuid(), actionData.getDescription())
-                    .onFailure(ExceptionReporterHandler.INSTANCE::report);
+            Result<ExtractorInput> extractorInputResult = assemblyHelper.buildExtractorInput(metaAction.getKey(), actionData.getUuid(), actionData.getDescription());
            AgentRuntimeException exception = extractorInputResult.exceptionOrNull();
            if (exception != null) {
                failureReason.set(exception.getMessage());
@@ -323,7 +320,6 @@ public class ActionExecutor extends AbstractAgentModule.Standalone {

            ExtractorInput extractorInput = extractorInputResult.getOrThrow();
            Result<ExtractorResult> extractorResultWrapped = paramsExtractor.execute(extractorInput).onFailure(exp -> {
-                ExceptionReporterHandler.INSTANCE.report(exp);
                failureReason.set(exp.getLocalizedMessage());
            });
            if (extractorResultWrapped.exceptionOrNull() != null) {
@@ -373,7 +369,6 @@ public class ActionExecutor extends AbstractAgentModule.Standalone {
        return () -> {
            try {
                return actionCorrectionRecognizer.execute(input)
-                        .onFailure(ExceptionReporterHandler.INSTANCE::report)
                        .getOrDefault(new CorrectionRecognizerResult());
            } finally {
                phaser.arriveAndDeregister();
@@ -515,7 +510,6 @@ public class ActionExecutor extends AbstractAgentModule.Standalone {

    private String resolveHistoryDescription(String actionKey) {
        return actionCapability.loadMetaActionInfo(actionKey)
-                .onFailure(ExceptionReporterHandler.INSTANCE::report)
                .fold(
                        metaActionInfo -> metaActionInfo.getDescription().isBlank() ? actionKey : metaActionInfo.getDescription(),
                        exception -> actionKey
--- a/Partner-Core/src/main/java/work/slhaf/partner/module/action/planner/ActionPlanner.java
+++ b/Partner-Core/src/main/java/work/slhaf/partner/module/action/planner/ActionPlanner.java
@@ -390,7 +390,6 @@ public class ActionPlanner extends AbstractAgentModule.Running<PartnerRunningFlo
                for (String actionKey : entry.getValue()) {
                    Result<MetaAction> metaActionResult = actionCapability.loadMetaAction(actionKey);
                    AgentRuntimeException failure = metaActionResult.onSuccess(metaActions::add)
-                            .onFailure(ExceptionReporterHandler.INSTANCE::report)
                            .exceptionOrNull();
                    if (failure != null) {
                        return null;
@@ -415,8 +414,7 @@ public class ActionPlanner extends AbstractAgentModule.Running<PartnerRunningFlo
                    for (String actionKey : actionKeys) {
                        // 根据 actionKey 加载行动信息,并检查是否存在必需前置依赖

-                        Result<MetaActionInfo> infoResult = actionCapability.loadMetaActionInfo(actionKey)
-                                .onFailure(ExceptionReporterHandler.INSTANCE::report);
+                        Result<MetaActionInfo> infoResult = actionCapability.loadMetaActionInfo(actionKey);
                        if (infoResult.exceptionOrNull() != null) {
                            return false;
                        }
--- a/Partner-Core/src/main/java/work/slhaf/partner/module/action/planner/evaluator/ActionEvaluator.java
+++ b/Partner-Core/src/main/java/work/slhaf/partner/module/action/planner/evaluator/ActionEvaluator.java
@@ -10,7 +10,6 @@ import work.slhaf.partner.core.cognition.BlockContent;
 import work.slhaf.partner.core.cognition.CognitionCapability;
 import work.slhaf.partner.core.cognition.ContextBlock;
 import work.slhaf.partner.core.cognition.ResolvedContext;
-import work.slhaf.partner.framework.agent.exception.ExceptionReporterHandler;
 import work.slhaf.partner.framework.agent.factory.capability.annotation.InjectCapability;
 import work.slhaf.partner.framework.agent.factory.component.abstracts.AbstractAgentModule;
 import work.slhaf.partner.framework.agent.factory.component.annotation.Init;
@@ -67,7 +66,7 @@ public class ActionEvaluator extends AbstractAgentModule.Sub<EvaluatorInput, Lis
                            messages,
                            EvaluatorResult.class
                    );
-                    result.onFailure(ExceptionReporterHandler.INSTANCE::report).onSuccess(evaluatorResult -> {
+                    result.onSuccess(evaluatorResult -> {
                        evaluatorResult.setTendency(tendency);
                        synchronized (evaluatorResults) {
                            evaluatorResults.add(evaluatorResult);
--- a/Partner-Core/src/main/java/work/slhaf/partner/module/action/planner/extractor/ActionExtractor.java
+++ b/Partner-Core/src/main/java/work/slhaf/partner/module/action/planner/extractor/ActionExtractor.java
@@ -3,6 +3,8 @@ package work.slhaf.partner.module.action.planner.extractor;
 import org.jetbrains.annotations.NotNull;
 import work.slhaf.partner.core.cognition.CognitionCapability;
 import work.slhaf.partner.core.cognition.ContextBlock;
+import work.slhaf.partner.framework.agent.exception.AgentRuntimeException;
+import work.slhaf.partner.framework.agent.exception.ModuleExecutionException;
 import work.slhaf.partner.framework.agent.factory.capability.annotation.InjectCapability;
 import work.slhaf.partner.framework.agent.factory.component.abstracts.AbstractAgentModule;
 import work.slhaf.partner.framework.agent.model.ActivateModel;
@@ -26,8 +28,15 @@ public class ActionExtractor extends AbstractAgentModule.Sub<String, Result<Extr
                )).encodeToMessage(),
                new Message(Message.Character.USER, input)
        );
-        return formattedChat(messages, ExtractorResult.class);
-
+        try {
+            return Result.success(formattedChat(messages, ExtractorResult.class).getOrThrow());
+        } catch (AgentRuntimeException e) {
+            return Result.failure(new ModuleExecutionException(
+                    "collecting action tendencies failed",
+                    this.getClass(),
+                    getModuleName()
+            ));
+        }
    }

    @NotNull
--- a/Partner-Core/src/main/java/work/slhaf/partner/module/communication/CommunicationProducer.java
+++ b/Partner-Core/src/main/java/work/slhaf/partner/module/communication/CommunicationProducer.java
@@ -6,7 +6,6 @@ import org.jetbrains.annotations.NotNull;
 import org.w3c.dom.Document;
 import org.w3c.dom.Element;
 import work.slhaf.partner.core.cognition.*;
-import work.slhaf.partner.framework.agent.exception.ExceptionReporterHandler;
 import work.slhaf.partner.framework.agent.factory.capability.annotation.InjectCapability;
 import work.slhaf.partner.framework.agent.factory.component.abstracts.AbstractAgentModule;
 import work.slhaf.partner.framework.agent.factory.component.annotation.Init;
@@ -69,7 +68,6 @@ public class CommunicationProducer extends AbstractAgentModule.Running<PartnerRu
        StreamChatMessageConsumer consumer = ReplyDispatcher.INSTANCE.createConsumer(runningFlowContext.getTarget());
        this.streamChat(buildChatMessages(runningFlowContext), consumer)
                .onFailure(exception -> {
-                    ExceptionReporterHandler.INSTANCE.report(exception);
                    consumer.onDelta(INTERRUPTED_MARKER);
                });
        updateChatMessages(runningFlowContext, consumer.collectResponse());
--- a/Partner-Core/src/main/java/work/slhaf/partner/module/memory/selector/evaluator/SliceSelectEvaluator.java
+++ b/Partner-Core/src/main/java/work/slhaf/partner/module/memory/selector/evaluator/SliceSelectEvaluator.java
@@ -46,7 +46,6 @@ public class SliceSelectEvaluator extends AbstractAgentModule.Sub<EvaluatorInput

    @Override
    public List<ActivatedMemorySlice> execute(EvaluatorInput evaluatorInput) {
-        log.debug("切片评估模块开始...");
        List<ActivatedMemorySlice> preparedSlices = evaluatorInput.getMemorySlices();
        List<ActivatedMemorySlice> result = new ArrayList<>();
        CountDownLatch latch = new CountDownLatch(preparedSlices.size());
@@ -65,7 +64,6 @@ public class SliceSelectEvaluator extends AbstractAgentModule.Sub<EvaluatorInput
                            resolveTaskMessage(batchInput)
                    );
                    formattedChat(messages, EvaluatorBatchResult.class)
-                            .onFailure(exception -> log.debug("切片评估失败，已跳过当前切片", exception))
                            .onSuccess(evaluatorBatchResult -> {
                                if (evaluatorBatchResult.isPassed()) {
                                    synchronized (result) {
@@ -83,7 +81,6 @@ public class SliceSelectEvaluator extends AbstractAgentModule.Sub<EvaluatorInput
            latch.await();
        } catch (InterruptedException ignored) {
        }
-        log.debug("切片评估模块结束...");

        return result;
    }
--- a/Partner-Core/src/main/java/work/slhaf/partner/module/memory/selector/extractor/MemorySelectExtractor.java
+++ b/Partner-Core/src/main/java/work/slhaf/partner/module/memory/selector/extractor/MemorySelectExtractor.java
@@ -8,7 +8,6 @@ import org.w3c.dom.Document;
 import org.w3c.dom.Element;
 import work.slhaf.partner.core.cognition.CognitionCapability;
 import work.slhaf.partner.core.cognition.ContextBlock;
-import work.slhaf.partner.framework.agent.exception.ExceptionReporterHandler;
 import work.slhaf.partner.framework.agent.factory.capability.annotation.InjectCapability;
 import work.slhaf.partner.framework.agent.factory.component.abstracts.AbstractAgentModule;
 import work.slhaf.partner.framework.agent.factory.component.annotation.InjectModule;
@@ -34,7 +33,6 @@ public class MemorySelectExtractor extends AbstractAgentModule.Sub<ExtractorInpu

    @Override
    public ExtractorResult execute(ExtractorInput input) {
-        log.debug("[MemorySelectExtractor] 主题提取模块开始...");
        ExtractorResult extractorResult;
        List<Message> messages = List.of(
                resolveContextMessage(),
@@ -44,7 +42,7 @@ public class MemorySelectExtractor extends AbstractAgentModule.Sub<ExtractorInpu
                messages,
                ExtractorResult.class
        );
-        extractorResult = result.onFailure(ExceptionReporterHandler.INSTANCE::report).fold(
+        extractorResult = result.fold(
                value -> value,
                exception -> {
                    ExtractorResult fallback = new ExtractorResult();
--- a/Partner-Core/src/main/java/work/slhaf/partner/module/memory/updater/summarizer/SingleSummarizer.java
+++ b/Partner-Core/src/main/java/work/slhaf/partner/module/memory/updater/summarizer/SingleSummarizer.java
@@ -4,7 +4,6 @@ import lombok.Data;
 import lombok.EqualsAndHashCode;
 import work.slhaf.partner.core.action.ActionCapability;
 import work.slhaf.partner.core.action.ActionCore;
-import work.slhaf.partner.framework.agent.exception.ExceptionReporterHandler;
 import work.slhaf.partner.framework.agent.factory.capability.annotation.InjectCapability;
 import work.slhaf.partner.framework.agent.factory.component.abstracts.AbstractAgentModule;
 import work.slhaf.partner.framework.agent.factory.component.annotation.Init;
@@ -41,7 +40,7 @@ public class SingleSummarizer extends AbstractAgentModule.Sub<List<Message>, Voi
                    int index = i;
                    executor.execute(() -> {
                        try {
-                            String summarized = chat(List.of(new Message(Message.Character.USER, content))).onFailure(ExceptionReporterHandler.INSTANCE::report).fold(
+                            String summarized = chat(List.of(new Message(Message.Character.USER, content))).fold(
                                    res -> res,
                                    exp -> content
                            );