mirror of
https://github.com/slhaf/Partner.git
synced 2026-05-12 16:53:04 +08:00
fix(ActionScheduler): use checkThenExecute current hour consistently and trigger wheel tasks outside lock
This commit is contained in:
@@ -124,7 +124,7 @@ class ActionScheduler : AgentRunningSubModule<Set<ScheduledActionData>, Void>()
|
||||
|
||||
val hour = parseToZonedDateTime.hour
|
||||
actionsGroupByHour[hour].add(actionData)
|
||||
if (recordHour == hour) {
|
||||
if (it.hour == hour) {
|
||||
state.value = WheelState.ACTIVE
|
||||
}
|
||||
|
||||
@@ -133,22 +133,20 @@ class ActionScheduler : AgentRunningSubModule<Set<ScheduledActionData>, Void>()
|
||||
|
||||
private fun launchWheel() {
|
||||
|
||||
fun tickOnTrigger(tick: Int, previousTick: Int) {
|
||||
fun collectToTrigger(tick: Int, previousTick: Int, triggerHour: Int): Set<ScheduledActionData>? {
|
||||
if (tick > previousTick) {
|
||||
val toTrigger = linkedSetOf<ScheduledActionData>()
|
||||
val toTrigger = mutableSetOf<ScheduledActionData>()
|
||||
for (i in (previousTick + 1)..tick) {
|
||||
val bucket = wheel[i]
|
||||
if (bucket.isNotEmpty()) {
|
||||
toTrigger.addAll(bucket)
|
||||
actionsGroupByHour[recordHour].removeAll(bucket)
|
||||
actionsGroupByHour[triggerHour].removeAll(bucket)
|
||||
bucket.clear() // 避免重复触发
|
||||
}
|
||||
}
|
||||
|
||||
if (toTrigger.isNotEmpty()) {
|
||||
onTrigger(toTrigger)
|
||||
}
|
||||
return toTrigger
|
||||
}
|
||||
return null
|
||||
}
|
||||
|
||||
suspend fun CoroutineScope.wheel(launchingTime: ZonedDateTime) {
|
||||
@@ -170,22 +168,27 @@ class ActionScheduler : AgentRunningSubModule<Set<ScheduledActionData>, Void>()
|
||||
lastTickAdvanceTime = current
|
||||
|
||||
var shouldBreak: Boolean? = null
|
||||
var toTrigger: Set<ScheduledActionData>? = null
|
||||
checkThenExecute {
|
||||
|
||||
if (recordHour != launchingHour) {
|
||||
// recordHour 在外部受到更新,不等于启动时的 hour,则需要停止
|
||||
if (it.hour != launchingHour) {
|
||||
// recordHout 已更新,此时后执行无意义,不等于启动时的 hour,则需要停止
|
||||
shouldBreak = true
|
||||
return@checkThenExecute
|
||||
}
|
||||
|
||||
toTrigger = collectToTrigger(tick, previousTick, it.hour)
|
||||
|
||||
// 推进到顶时停止循环、当前时无任务时停止循环
|
||||
if (tick >= wheel.lastIndex || actionsGroupByHour[recordHour].isEmpty()) {
|
||||
if (tick >= wheel.lastIndex || actionsGroupByHour[it.hour].isEmpty()) {
|
||||
state.value = WheelState.SLEEPING
|
||||
shouldBreak = true
|
||||
return@checkThenExecute
|
||||
}
|
||||
|
||||
// 取当前 tick、推进过程中经过的 tick 对应任务,异步启动
|
||||
tickOnTrigger(tick, previousTick)
|
||||
}
|
||||
toTrigger?.let { onTrigger(it) }
|
||||
if (shouldBreak!!) {
|
||||
break
|
||||
}
|
||||
@@ -203,7 +206,6 @@ class ActionScheduler : AgentRunningSubModule<Set<ScheduledActionData>, Void>()
|
||||
withTimeoutOrNull(seconds) {
|
||||
state.first { it == WheelState.ACTIVE }
|
||||
}
|
||||
state.value = WheelState.SLEEPING
|
||||
}
|
||||
|
||||
timeWheelScope.launch {
|
||||
@@ -213,7 +215,7 @@ class ActionScheduler : AgentRunningSubModule<Set<ScheduledActionData>, Void>()
|
||||
var currentTime: ZonedDateTime? = null
|
||||
checkThenExecute {
|
||||
currentTime = it
|
||||
shouldWait = actionsGroupByHour[recordHour].isEmpty()
|
||||
shouldWait = actionsGroupByHour[it.hour].isEmpty()
|
||||
}
|
||||
|
||||
// 如果该时无任务则等待,插入事件可提前唤醒
|
||||
@@ -229,30 +231,13 @@ class ActionScheduler : AgentRunningSubModule<Set<ScheduledActionData>, Void>()
|
||||
}
|
||||
}
|
||||
|
||||
suspend fun checkThenExecute(then: (currentTime: ZonedDateTime) -> Unit) =
|
||||
wheelActionsLock.withLock {
|
||||
val currentTime = ZonedDateTime.now()
|
||||
val currentDay = currentTime.dayOfMonth
|
||||
if (currentDay != recordDay) {
|
||||
recordDay = currentDay
|
||||
recordHour = currentTime.hour
|
||||
loadDayActions()
|
||||
loadHourActions()
|
||||
} else if (currentTime.hour != recordHour) {
|
||||
recordHour = currentTime.hour
|
||||
loadHourActions()
|
||||
}
|
||||
|
||||
then(currentTime)
|
||||
}
|
||||
|
||||
suspend fun checkThenExecute(then: (currentTime: ZonedDateTime) -> Unit) = wheelActionsLock.withLock {
|
||||
fun loadActions(
|
||||
now: ZonedDateTime,
|
||||
load: (latestExecutingTime: ZonedDateTime, actionData: ScheduledActionData) -> Unit,
|
||||
invalid: (before: ZonedDateTime, after: ZonedDateTime) -> Boolean,
|
||||
repair: () -> Unit
|
||||
) {
|
||||
val runLoading = {
|
||||
val now = ZonedDateTime.now()
|
||||
for (actionData in listScheduledActions()) {
|
||||
val latestExecutingTime =
|
||||
parseToZonedDateTime(
|
||||
@@ -268,50 +253,52 @@ class ActionScheduler : AgentRunningSubModule<Set<ScheduledActionData>, Void>()
|
||||
}
|
||||
}
|
||||
|
||||
val before = ZonedDateTime.now()
|
||||
runLoading()
|
||||
val after = ZonedDateTime.now()
|
||||
if (invalid(before, after)) {
|
||||
repair()
|
||||
runLoading()
|
||||
}
|
||||
}
|
||||
|
||||
fun loadHourActions() {
|
||||
fun loadHourActions(currentTime: ZonedDateTime) {
|
||||
val load: (ZonedDateTime, ScheduledActionData) -> Unit = { latestExecutionTime, actionData ->
|
||||
val secondsTime = latestExecutionTime.minute * 60 + latestExecutionTime.second
|
||||
wheel[secondsTime].add(actionData)
|
||||
}
|
||||
|
||||
val invalid: (ZonedDateTime, ZonedDateTime) -> Boolean = { before, after ->
|
||||
before.hour != after.hour
|
||||
}
|
||||
|
||||
val repair: () -> Unit = {
|
||||
for (set in wheel) {
|
||||
set.clear()
|
||||
}
|
||||
}
|
||||
|
||||
loadActions(load, invalid, repair)
|
||||
loadActions(currentTime, load, repair)
|
||||
}
|
||||
|
||||
fun loadDayActions() {
|
||||
fun loadDayActions(currentTime: ZonedDateTime) {
|
||||
val load: (ZonedDateTime, ScheduledActionData) -> Unit = { latestExecutingTime, actionData ->
|
||||
actionsGroupByHour[latestExecutingTime.hour].add(actionData)
|
||||
}
|
||||
|
||||
val invalid: (ZonedDateTime, ZonedDateTime) -> Boolean = { before, after ->
|
||||
before.dayOfMonth != after.dayOfMonth
|
||||
}
|
||||
|
||||
val repair: () -> Unit = {
|
||||
for (set in actionsGroupByHour) {
|
||||
set.clear()
|
||||
}
|
||||
}
|
||||
|
||||
loadActions(load, invalid, repair)
|
||||
loadActions(currentTime, load, repair)
|
||||
}
|
||||
|
||||
val currentTime = ZonedDateTime.now()
|
||||
val currentDay = currentTime.dayOfMonth
|
||||
if (currentDay != recordDay) {
|
||||
recordDay = currentDay
|
||||
recordHour = currentTime.hour
|
||||
loadDayActions(currentTime)
|
||||
loadHourActions(currentTime)
|
||||
} else if (currentTime.hour != recordHour) {
|
||||
recordHour = currentTime.hour
|
||||
loadHourActions(currentTime)
|
||||
}
|
||||
|
||||
then(currentTime)
|
||||
}
|
||||
|
||||
private fun parseToZonedDateTime(
|
||||
|
||||
Reference in New Issue
Block a user